Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safewrite Option2 #9

Closed
wants to merge 3 commits into from
Closed

Safewrite Option2 #9

wants to merge 3 commits into from

Conversation

rgaskill
Copy link
Contributor

Allow for safe write editors.

@rgaskill
Copy link
Contributor Author

A different approach to #6.

@shama
Copy link
Owner

shama commented Dec 14, 2012

Working flawlessly on OSX and benchmarking roughly the same. Looking forward to trying on Windows, Ubuntu and reviewing further later. Thank you for your excellent work!

@shama
Copy link
Owner

shama commented Dec 14, 2012

Works beautifully on Windows 7 and Ubuntu 12.04. Seriously nice work Roarke! Will merge this shortly.

@shama shama mentioned this pull request Dec 14, 2012
@mikesmullin
Copy link

working fast and reliably for me on ubuntu 12.04. thx

@rgaskill
Copy link
Contributor Author

@shama I am glad it is working so well on the other platforms. I just committed some cleanup of unused code. Everything should be good to go for a merge.

One thing to note is I had to change some of the unit tests because of how watchFile works. watchFile will not fire an event if the file changes between the watchFile is registered and the first poll interval. This is why I added the time out to some of the unit tests. With out it the file changes within that first interval and no event was fired.

@shama shama closed this in 6ed645e Dec 14, 2012
@shama
Copy link
Owner

shama commented Dec 14, 2012

Merged and bumped to v0.3.0. Fantastic work Roarke, thanks again for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants